Skip to content

Isolate build script metadata progation between std and non-std crates #16489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weihanglo merged 1 commit into from
Jan 9, 2026
+5 −0
Merged

Isolate build script metadata progation between std and non-std crates #16489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/cargo/core/compiler/custom_build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,11 @@ fn build_work(build_runner: &mut BuildRunner<'_, '_>, unit: &Unit) -> CargoResul
// sorts of variables need to be discovered at that time.
let lib_deps = dependencies
.iter()
// We allow std dependencies to propagate metadata between other std dependencies but
// not to non-std crates. Non-std crates can propagate metadata to other non-std crates.
// We enforce a boundary between std and non-std crates. This may be lifted in the
// future but for now we are being conservative.
.filter(|dep| dep.unit.is_std == unit.is_std)
.filter_map(|dep| {
if dep.unit.mode.is_run_custom_build() {
let dep_metadata = build_runner.get_run_build_script_metadata(&dep.unit);
Expand Down