chore: point chalk-integration to new salsa #819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
requested changes
Dec 11, 2024
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
I don't think we should accept this until there's a published release on crates.io (though, not sure why rust-analyzer would need this)
Member
|
Maybe this should be merged before #825? |
Member
|
I still think this is not required at all |
Contributor
Author
|
Whoops, closing this. Turns out, this was not needed for the migration! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of a boring change, but we need this in order to migrate rust-analyzer to the new Salsa (see: https://rust-lang.zulipchat.com/#narrow/channel/185405-t-compiler.2Frust-analyzer/topic/Porting.20to.20Salsa.203.2E0/near/487299583) and, eventually, off Chalk onto the new trait solver.
(Please hold off on merging this until salsa-rs/salsa#623 lands and https://github.com/davidbarsky/db-ext-macro/ is published.)