controllers/version: Add traits to help reduce data loading #10603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eth3lbert
added
C-enhancement ✨
Instead of loading them individually, this gets both in one query. I think that in most cases, the request to query for `Crate` and `Version` will have valid input, so this seems like a better approach, even though it might only give a small performance boost.
…`crate_and_version()` fn Since most endpoints don't need all of the columns for `crates` and `versions`, it would be great to only load the columns we actually need to make things faster. This will enable other endpoints to use the function to make a base query and customize the needed columns.
eth3lbert
force-pushed
the
crate-and-version
branch
from
ffff496 to
1028929
Compare
|
Rebased and conflict resolved! |
Turbo87
reviewed
Feb 25, 2025
There was a problem hiding this comment.
I'm somewhat unsure whether the extra complexity is worth it. @LawnGnome any opinions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR primarily addresses three things:
CrateandVersionin a single query.Cratewhen onlyVersionis needed.First, I assume that in most cases, the given inputs are valid, then it would be great to load them in a single query.
Second, since most endpoints do not require all columns from
CrateandVersion, it would be nice to load only the necessary columns to reduce data loading.Third, when only
Versionis required, it would be ideal to load only the ID ofCrateto determine its existence.I hope this doesn't overly complicate things :)