Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown: Add tasklist test cases #10913

Merged
merged 1 commit into from
Apr 7, 2025
Merged

Conversation

jendrikw
Copy link
Contributor

@jendrikw jendrikw commented Mar 28, 2025

The test are currently failing, which indicates a bug. From my understanding, the test should pass.

As per this URLO thread: https://users.rust-lang.org/t/missing-list-item-names-in-the-readme-on-crates-io/127558

You can see the bug live in action at
https://crates.io/crates/Yoda/0.11.5

@Turbo87
Copy link
Member

Turbo87 commented Apr 2, 2025

@jendrikw we are using https://github.com/kivikakk/comrak for the markdown rendering. if the conversion fails here then its probably best to report this upstream in their bug tracker, then the bugfix should automatically land on crates.io once it's fixed.

@Turbo87
Copy link
Member

Turbo87 commented Apr 2, 2025

Reported at kivikakk/comrak#558

@Turbo87 Turbo87 changed the title test various markdown elements after checkboxes markdown: Add tasklist test cases Apr 7, 2025
The test are currently failing, which indicates a
bug.

As per this URLO thread: https://users.rust-lang.org/t/missing-list-item-names-in-the-readme-on-crates-io/127558

You can see the bug live in action at
https://crates.io/crates/Yoda/0.11.5
@Turbo87
Copy link
Member

Turbo87 commented Apr 7, 2025

looks like kivikakk/comrak#559 fixed the issue 🎉

@Turbo87 Turbo87 merged commit ff9e6f7 into rust-lang:main Apr 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants