Allow emails table to contain multiple emails per user
#11642
+758
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kailan
force-pushed
the
multiple-emails-schema
branch
3 times, most recently
from
f6ebfe0 to
77ebf49
Compare
kailan
force-pushed
the
multiple-emails-schema
branch
from
77ebf49 to
edf516e
Compare
kailan
commented
Jul 26, 2025
| @@ -538,6 +538,9 @@ diesel::table! { | |||
| /// | |||
| /// (Automatically generated by Diesel.) | |||
| token_generated_at -> Nullable<Timestamptz>, | |||
| /// Whether this email is the primary email address for the user. | |||
| #[sql_name = "is_primary"] | |||
There was a problem hiding this comment.
primary is a reserved keyword in Postgres, so we use is_primary as the column name and then alias it to primary in the Diesel schema to be consistent with verified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is split from #11629 – it contains just the database schema-related changes, with no changes to the API, frontend, or any user-visible behaviour, barring a change to the description of three properties of the
/api/v1/meresponse in the OpenAPI schema.I previously had a note here about it being possible for an email address to exist on more than one user account, but this is the current behaviour in production so I have removed it.
Relates to #11597.