-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing centered CSS class #2060
Add missing centered CSS class #2060
Conversation
071b009
to
a2196a6
Compare
These pages being left-aligned was an explicit change #2012 |
Even the search results and the non "main" crate pages? |
The docs.rs crate pages, yes that was definitely called out in the PR, and the search page is one of the "release pages". |
(Pages that looks like they could do with a bit of style work to make left-alignment look better are https://docs.rs/crate/serde/1.0.152/builds and https://docs.rs/crate/serde/1.0.152/builds/709459, those are the only ones without a left-sidebar). |
Okay, gonna update the PR then. |
a2196a6
to
e26ed54
Compare
Put back the left align like mentioned. |
cc @jsha since you have more context on what the overall plan of left aligning was. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The idea with left-aligning is that the rustdoc pages themselves are left-aligned, and the crate pages are related to them, so it's jarring to go back and forth between left-aligned and right-aligned.
For the homepage and various pages that show search results, it's reasonable to be centered, IMO.
In this PR, builds and build_details should ideally be left-aligned, but given that their layout is currently messed up when left-aligned I'm fine landing this as a quick fix. We should later follow up and left-align them with appropriate padding.
Ok, merging then. Thanks for the feedback! |
Fixes cases like this (content is completely on the left, leaving big "empty space" on the right):
As a reminder, #1698 is still waiting for feedback to prevent regressions like this to happen. ;)