optionally collect compiler metrics #2812
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
| if self.config.compiler_metrics_collection_path.is_some() { | ||
| // set the `./target/metrics/` directory inside the build container | ||
| // as a target directory for the metric files. | ||
| let flag = "-Zmetrics-dir=/opt/rustwide/target/metrics"; |
There was a problem hiding this comment.
Were you able to make it work?
There was a problem hiding this comment.
( there are output files generated)
There was a problem hiding this comment.
Even for:
#![feature(doc_cfg)]
//! ```
//! macro_rules! bla {
//! ($($x:tt)*) => {}
//! }
//! ```
?
There was a problem hiding this comment.
Do you have a crate / release on crates.io I can just run it with?
There was a problem hiding this comment.
No, it's just a test I wrote locally. You can do so as well:
cargo new --lib foo
cd foo
# copy content into it
# run cargo doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a draft as a base for discussion.
Generally we want to separate the build output between builds / releases so I'm just using the target directory and copy over the json files afterwards.
What's missing is some kind of ICE protection, where we would retry the build without metrics in case of ICEs, or just collect metrics on the first try.
Also I would like to add tests.