Skip to content

Fix JS error when menu is closed and alt key is pressed #2846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jun 19, 2025

image

Here's how I trigger the bug:

  1. Open a topbar menu.
  2. Close it by clicking on text in the document
  3. Press the alt key.

Now the fun part: it doesn't happen all the time so can't really write a GUI test for it. ^^'

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner June 19, 2025 15:11
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jun 19, 2025
Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can still reproduce the error with these changes, or is it just another place?

( I tried with the "About" menu )

@syphar
Copy link
Member

syphar commented Jun 19, 2025

Also, the real question is:
how did you end up discovering this issue? 😄

@GuillaumeGomez
Copy link
Member Author

I can still reproduce the error with these changes, or is it just another place?

( I tried with the "About" menu )

Hum, weird. Gonna test some more then.

Also, the real question is:

how did you end up discovering this issue? 😄

A human needs to have their secret. 😛 (I literally just saw an error after switching windows when working on #2847)

@GuillaumeGomez
Copy link
Member Author

Ah indeed. So parentNode can exist without having classList. Ok whatever, it's JS.

@syphar syphar merged commit d932948 into rust-lang:master Jun 20, 2025
9 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jun 20, 2025
@GuillaumeGomez GuillaumeGomez deleted the fix-js-error branch June 20, 2025 07:53
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants