chore(macro): bump syn to v3 - #3028
Open
AudaciousAxiom wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
AudaciousAxiom
commented
Jul 27, 2026
| proc-macro2 = "1.0.60" | ||
| quote = "1.0" | ||
| syn = { version = "2.0.52", features = ["full"] } | ||
| syn = { version = "3.0", features = ["full"] } |
Author
There was a problem hiding this comment.
Alternatively, it should also be possible to allow both, to avoid bringing in the v3 in dependents that still depend on the v2 and don't (yet) require the v3:
Suggested change
| syn = { version = "3.0", features = ["full"] } | |
| syn = { version = ">= 2.0.52, < 4.0", features = ["full"] } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the release of a new major version of
syn, this bumps the version used byfutures-macro, with the goal of eventually removing the duplicated dependency in binaries (and therefore reducing compile times).synv3 advertises an MSRV of 1.71, so this shouldn't affect the MSRV of this crate.synv3 of course contains breaking changes: I've been through the changelog but didn't find anything relevant (but there are quite a few of them so I could have missed some). I've runcargo test --all-featuresbut didn't do any other kind of testing.