Escape auto-linked GitHub usernames more precisely #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaliaarchi
force-pushed
the
precise-username-escaping
branch
from
670b952 to
e25ca63
Compare
More precisely match how GitHub auto-links usernames when escaping usernames to suppress pings. Perhaps most noticeably, this now keeps punctuation outside of the escaped username.
thaliaarchi
force-pushed
the
precise-username-escaping
branch
from
e25ca63 to
184c2df
Compare
|
CI has really picky code style 😅 |
|
This needs handling of teams. Since I'm not in |
|
Just noting that performing non-trivial changes to homu might be a bit futile at the moment. We're in the processing of reimplementing the bot in Rust (https://github.com/rust-lang/bors). Created an issue for this: rust-lang/bors#258. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More precisely match how GitHub auto-links usernames when escaping usernames to suppress pings.
Perhaps most noticeably, this now keeps punctuation outside of the escaped username.
You can verify that this matches GitHub's behavior by copying the test string (with strings concatenated and
\ns resolved, of course) into a Markdown editor on GitHub and comparing what is auto-linked when rendered.Improves upon #100.