run clippy on 3 major platforms

Author: nyurik

.github/workflows/ci.yaml

@@ -30,11 +30,15 @@ jobs:
         run: ./ci/style.sh
 
   clippy:
-    name: Clippy check
-    runs-on: ubuntu-24.04
+    name: Clippy on ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-24.04, macos-14, windows-2022]
+    runs-on: ${{ matrix.os }}
     timeout-minutes: 10
     steps:
       - uses: actions/checkout@v4
+      - run: rustup update stable --no-self-update
       - uses: Swatinem/rust-cache@v2
       # Here we use the latest stable Rust toolchain already installed by GitHub
       # Ideally we should run it for every target, but we cannot rely on unstable toolchains
@@ -299,7 +303,8 @@ jobs:
       - verify_build
       - ctest_msrv
       - docs
-    # Github branch protection is exceedingly silly and treats "jobs skipped because a dependency
+      - clippy
+    # GitHub branch protection is exceedingly silly and treats "jobs skipped because a dependency
     # failed" as success. So we have to do some contortions to ensure the job fails if any of its
     # dependencies fails.
     if: always() # make sure this is never "skipped"

Cargo.toml

@@ -143,20 +143,19 @@ members = [
     "libc-test",
 ]
 
-#
-# TODO: These should be renamed as `[workspace.lints.*]` once MSRV is abve 1.64
+# FIXME(msrv): These should be renamed as `[workspace.lints.*]` once MSRV is above 1.64
 #       This way all crates can use it with `[lints] workspace=true` section
-#
 
 [lints.rust]
-# TODO: make ident usage consistent in each file
+# FIXME(cleanup): make ident usage consistent in each file
 unused_qualifications = "allow"
 
 [lints.clippy]
-# TODO: all these are default lints and should probably be fixed
+missing_safety_doc = "allow"
+
+# FIXME(clippy): all these are default lints and should probably be fixed
 identity_op = "allow"
 if_same_then_else = "allow"
-missing_safety_doc = "allow"
 non_minimal_cfg = "allow"
 precedence = "allow"
 redundant_field_names = "allow"

ctest-test/Cargo.toml

@@ -25,20 +25,14 @@ test = false
 name = "t1_cxx"
 test = false
 
-[[bin]]
-name = "t2_cxx"
-test = false
-
+# FIXME(msrv): These should be moved to the root Cargo.toml as `[workspace.lints.*]`
+#              once MSRV is above 1.64 and replaced with `[lints] workspace=true`
 #
-# TODO: These should be moved to the root Cargo.toml as `[workspace.lints.*]` once MSRV is abve 1.64
-#       replace it with `[lints] workspace=true`
-#
-
 [lints.rust]
-# TODO: make ident usage consistent in each file
+# FIXME(cleanup): make ident usage consistent in each file
 unused_qualifications = "allow"
 
 [lints.clippy]
-# TODO: fix these, and enable pedantic lints with needed exceptions
+# FIXME(clippy): fix these
 match_like_matches_macro = "allow"
 eq_op = "allow"

ctest/Cargo.toml

@@ -14,17 +14,15 @@ cc = "1.0.1"
 rustc_version = "0.4"
 indoc = "2.0.6"
 
+# FIXME(msrv): These should be moved to the root Cargo.toml as `[workspace.lints.*]`
+#              once MSRV is above 1.64 and replaced with `[lints] workspace=true`
 #
-# TODO: These should be moved to the root Cargo.toml as `[workspace.lints.*]` once MSRV is abve 1.64
-#       replace it with `[lints] workspace=true`
-#
-
 [lints.rust]
-# TODO: make ident usage consistent in each file
+# FIXME(cleanup): make ident usage consistent in each file
 unused_qualifications = "allow"
 
 [lints.clippy]
-# TODO: fix these, and enable pedantic lints with needed exceptions
+# FIXME(clippy): fix these
 doc_lazy_continuation = "allow"
 if_same_then_else = "allow"
 needless_borrow = "allow"

libc-test/Cargo.toml

@@ -103,17 +103,15 @@ name = "style_tests"
 path = "test/style_tests.rs"
 harness = true
 
+# FIXME(msrv): These should be moved to the root Cargo.toml as `[workspace.lints.*]`
+#              once MSRV is above 1.64 and replaced with `[lints] workspace=true`
 #
-# TODO: These should be moved to the root Cargo.toml as `[workspace.lints.*]` once MSRV is abve 1.64
-#       replace it with `[lints] workspace=true`
-#
-
 [lints.rust]
-# TODO: make ident usage consistent in each file
+# FIXME(cleanup): make ident usage consistent in each file
 unused_qualifications = "allow"
 
 [lints.clippy]
-# TODO: fix these, and enable pedantic lints with needed exceptions
+# FIXME(clippy): fix these
 needless_return = "allow"
 comparison_to_empty = "allow"
 unused_io_amount = "allow"