Skip to content

Define SO_BINDTOIFINDEX on Android #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

ningyuan-wang
Copy link
Contributor

@ningyuan-wang ningyuan-wang commented Apr 11, 2025

Android supports SO_BINDTOIFINDEX since SDK level 31: https://cs.android.com/android/platform/superproject/main/+/main:prebuilts/vndk/v31/arm/include/bionic/libc/kernel/uapi/asm-generic/socket.h;l=88;drc=684b16d3ce1e891ebe15d5678e12fa05ee6dd6e4

Description

Android supports SO_BINDTOIFINDEX since SDK level 31, which is introduced to support kernel v5.1.3.

Fixes: #4390

Sources

Android: Earliest support since SDK level 31: https://cs.android.com/android/platform/superproject/main/+/main:prebuilts/vndk/v31/arm/include/bionic/libc/kernel/uapi/asm-generic/socket.h;l=88;drc=684b16d3ce1e891ebe15d5678e12fa05ee6dd6e4
Current support in bionic: https://cs.android.com/android/platform/superproject/main/+/main:bionic/libc/kernel/uapi/asm-generic/socket.h;l=76;drc=65552ba5db8f299144172d4464350f1363a95304

Checklist

  • [+] Relevant tests in libc-test/semver have been updated
  • [+] No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • [+] Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2025

Some changes occurred in the Android module

cc @maurer

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rustbot label +stable-nominated

@rustbot rustbot added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Apr 11, 2025
@tgross35 tgross35 enabled auto-merge April 11, 2025 17:14
@tgross35 tgross35 added this pull request to the merge queue Apr 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 11, 2025
@tgross35 tgross35 added this pull request to the merge queue Apr 11, 2025
Merged via the queue into rust-lang:main with commit f80833c Apr 11, 2025
47 checks passed
@tgross35 tgross35 mentioned this pull request Apr 11, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-android O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define SO_BINDTOIFINDEX on Android
4 participants