chore: use auto-derived copy/clone impls#4417
Closed
nyurik wants to merge 2 commits intorust-lang:mainfrom
Closed
Conversation
Collaborator
Contributor
|
I'm not sure if it would work but you can try adding Line 65 in 0fe1d45 |
Contributor
Author
|
@tgross35 thx, but I am still getting a really strange warning in the style check -- what is an |
Contributor
|
Most of the binding structs are wrapped in @rustbot author |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
Unless there is something really magical, it doesn't seem to make sense to have manual impl for the most commonly used traits
Contributor
|
This has been resolved through a series of cleanup patches, so isn't relevant anymore. Thanks for the work here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unless there is something really magical, it doesn't seem to make sense to have manual impl for the most commonly used traits
@rustbot label +stable-nominated