Skip to content

adding SO_SPLICE socket option support for freebsd >= 14.2 #4451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2025
Merged

adding SO_SPLICE socket option support for freebsd >= 14.2 #4451

merged 1 commit into from
May 13, 2025

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented May 10, 2025 •
edited
Loading

ref and
ref

@tgross35
Copy link
Contributor

@devnexen could you please add a link to the headers in the description? I can't find anything from a quick search.

@asomers could you review this?

asomers
asomers approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM except that the change to src/windows/mod.rs is unrelated and needs to be reverted.

tgross35
tgross35 approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM except that the change to src/windows/mod.rs is unrelated and needs to be reverted.

... that explains why I couldn't find get_tzname for FreeBSD. Thanks for the catch.

@tgross35 tgross35 added this pull request to the merge queue May 13, 2025
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label May 13, 2025
Merged via the queue into rust-lang:main with commit 1f03301 May 13, 2025
48 of 50 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@devnexen @tgross35
adding SO_SPLICE socket option support for freebsd >= 14.2
830c67c 
[ref](https://github.com/freebsd/freebsd-src/blob/d3f15bc2a51d1822795135d9ad4627dc1c7f2b18/sys/sys/socket.h#L175) and
[ref](https://github.com/freebsd/freebsd-src/blob/d3f15bc2a51d1822795135d9ad4627dc1c7f2b18/sys/sys/socketvar.h#L76)

(backport <rust-lang#4451>)
(cherry picked from commit 47ac2e7)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
@devnexen @tgross35
adding SO_SPLICE socket option support for freebsd >= 14.2
40c1f31 
[ref](https://github.com/freebsd/freebsd-src/blob/d3f15bc2a51d1822795135d9ad4627dc1c7f2b18/sys/sys/socket.h#L175) and
[ref](https://github.com/freebsd/freebsd-src/blob/d3f15bc2a51d1822795135d9ad4627dc1c7f2b18/sys/sys/socketvar.h#L76)

(backport <rust-lang#4451>)
(cherry picked from commit 47ac2e7)
@tgross35 tgross35 mentioned this pull request Jun 1, 2025
Merged
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers asomers approved these changes

@tgross35 tgross35 tgross35 approved these changes

Assignees
No one assigned
Labels
O-unix O-windows S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devnexen @tgross35 @asomers @rustbot