-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Ensure cargo fmt
is run on all files
#4454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently only `src/` is checked. Add a run that covers everything else. This does mean files in `src/` get formatted twice, but `cargo fmt` doesn't support an `--exclude` option.
There are no longer any shell files in `ctest/`, so this FIXME can be resolved. Also move this to the end so missing shellcheck doesn't exit before the sort checks.
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
(backport <rust-lang#4454>) (cherry picked from commit adcb2b8)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
Currently only `src/` is checked. Add a run that covers everything else. This does mean files in `src/` get formatted twice, but `cargo fmt` doesn't support an `--exclude` option. (backport <rust-lang#4454>) (cherry picked from commit 1ca8b36)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
There are no longer any shell files in `ctest/`, so this FIXME can be resolved. Also move this to the end so missing shellcheck doesn't exit before the sort checks. (backport <rust-lang#4454>) [ Note - this backport doesn't do much since `ctest/` was never excluded, but it does keep file structure in sync - Trevor ] (cherry picked from commit 654bf4e)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
(backport <rust-lang#4454>) (cherry picked from commit adcb2b8)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
Currently only `src/` is checked. Add a run that covers everything else. This does mean files in `src/` get formatted twice, but `cargo fmt` doesn't support an `--exclude` option. (backport <rust-lang#4454>) (cherry picked from commit 1ca8b36)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
There are no longer any shell files in `ctest/`, so this FIXME can be resolved. Also move this to the end so missing shellcheck doesn't exit before the sort checks. (backport <rust-lang#4454>) [ note - this backport doesn't do much since `ctest/` was never excluded, but it does keep file structure in sync - Trevor ] (cherry picked from commit 654bf4e)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ctest
Issues relating to the ctest crate
O-windows
S-waiting-on-review
stable-applied
This PR has been cherry-picked to libc's stable release branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit messages for details.