Skip to content

Add arc4random and arc4random_buf to NuttX #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

Conversation

no1wudi
Copy link
Contributor

@no1wudi no1wudi commented May 28, 2025

Description

  • Declare arc4random and arc4random_buf as extern "C" functions in the NuttX module
  • Enable access to system-provided random number generation for NuttX targets
  • Aligns NuttX FFI with other Unix platforms that expose these functions

This change allows Rust code targeting NuttX to use arc4random and arc4random_buf for secure random number generation, improving compatibility and feature parity with other targets.

Sources

https://github.com/apache/nuttx/blob/302ceb701b2d28ab16aa421e2dc5c70ec0dd594e/include/stdlib.h#L155-L156

@rustbot label +stable-nominated

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

* Declare `arc4random` and `arc4random_buf` as extern "C" functions in the NuttX module
* Enable access to system-provided random number generation for NuttX targets
* Aligns NuttX FFI with other Unix platforms that expose these functions

This change allows Rust code targeting NuttX to use `arc4random` and `arc4random_buf` for secure random number generation, improving compatibility and feature parity with other targets.
@rustbot rustbot added O-unix S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels May 28, 2025
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tgross35 tgross35 added this pull request to the merge queue May 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2025
@tgross35 tgross35 added this pull request to the merge queue May 28, 2025
Merged via the queue into rust-lang:main with commit 5c06810 May 28, 2025
49 of 50 checks passed
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
* Declare `arc4random` and `arc4random_buf` as extern "C" functions in the NuttX module
* Enable access to system-provided random number generation for NuttX targets
* Aligns NuttX FFI with other Unix platforms that expose these functions

This change allows Rust code targeting NuttX to use `arc4random` and `arc4random_buf` for secure random number generation, improving compatibility and feature parity with other targets.

(backport <rust-lang#4464>)
(cherry picked from commit f8e4746)
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 1, 2025
* Declare `arc4random` and `arc4random_buf` as extern "C" functions in the NuttX module
* Enable access to system-provided random number generation for NuttX targets
* Aligns NuttX FFI with other Unix platforms that expose these functions

This change allows Rust code targeting NuttX to use `arc4random` and `arc4random_buf` for secure random number generation, improving compatibility and feature parity with other targets.

(backport <rust-lang#4464>)
(cherry picked from commit f8e4746)
@tgross35 tgross35 mentioned this pull request Jun 1, 2025
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants