Skip to content

Add ctest-next stub and expected dependencies #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2025

Conversation

mbyx
Copy link
Contributor

@mbyx mbyx commented Jun 1, 2025

Description

As part of setup, I have added a new library called ctest-next for the new version of ctest. Additionally I have already added two dependencies which will most likely be needed immediately after I start, and added the library as a workspace member.

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot rustbot added ctest Issues relating to the ctest crate S-waiting-on-review labels Jun 1, 2025
Cargo.toml Outdated
@@ -138,7 +138,7 @@ extra_traits = []

[workspace]
members = [
"ctest",
"ctest", "ctest-next",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline please

name = "ctest-next"
version = "0.1.0"
edition = "2021"
rust-version = "1.77"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also get:

license = "MIT OR Apache-2.0"
repository = "https://github.com/rust-lang/libc"
publish = false

Comment on lines 7 to 9
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be deleted

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please squash them this can merge

@mbyx mbyx force-pushed the ctest-next-stub branch from 5a15f38 to e36aadf Compare June 2, 2025 18:53
@mbyx mbyx force-pushed the ctest-next-stub branch from e36aadf to 0763c65 Compare June 2, 2025 18:58
@tgross35 tgross35 added this pull request to the merge queue Jun 2, 2025
Merged via the queue into rust-lang:main with commit b8e90fc Jun 2, 2025
50 of 51 checks passed
@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Jun 2, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 3, 2025
(backport <rust-lang#4467>)
[ remove dependencies so this can remain a stub - Trevor ]
(cherry picked from commit 0763c65)
@tgross35 tgross35 mentioned this pull request Jun 3, 2025
tgross35 pushed a commit to tgross35/rust-libc that referenced this pull request Jun 3, 2025
(backport <rust-lang#4467>)
[ remove dependencies so this can remain a stub - Trevor ]
(cherry picked from commit 0763c65)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ctest Issues relating to the ctest crate S-waiting-on-review stable-applied This PR has been cherry-picked to libc's stable release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants