-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ctest-next stub and expected dependencies #4467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Cargo.toml
Outdated
@@ -138,7 +138,7 @@ extra_traits = [] | |||
|
|||
[workspace] | |||
members = [ | |||
"ctest", | |||
"ctest", "ctest-next", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline please
name = "ctest-next" | ||
version = "0.1.0" | ||
edition = "2021" | ||
rust-version = "1.77" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also get:
license = "MIT OR Apache-2.0"
repository = "https://github.com/rust-lang/libc"
publish = false
ctest-next/Cargo.toml
Outdated
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be deleted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Please squash them this can merge
(backport <rust-lang#4467>) [ remove dependencies so this can remain a stub - Trevor ] (cherry picked from commit 0763c65)
(backport <rust-lang#4467>) [ remove dependencies so this can remain a stub - Trevor ] (cherry picked from commit 0763c65)
Description
As part of setup, I have added a new library called ctest-next for the new version of ctest. Additionally I have already added two dependencies which will most likely be needed immediately after I start, and added the library as a workspace member.
Checklist
libc-test/semver
have been updated*LAST
or*MAX
areincluded (see #3131)
cd libc-test && cargo test --target mytarget
);especially relevant for platforms that may not be checked in CI