This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Closed
Conversation
tesuji
force-pushed
the
floorf
branch
2 times, most recently
from
b48c68a to
b0edbd8
Compare
Member
|
Thanks for the PR! I have the same questions as #169 for this though. Why is this change being made relative to what's currently already implemented? |
Closed
This reverts commit b4aed3f.
Author
|
Seems like we don't agree the merge this. Closing then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ported from https://github.com/eblot/newlib/blob/master/newlib/libm/math/sf_floor.c
Blocked on #173
r? @japaric