-
Notifications
You must be signed in to change notification settings - Fork 386
Support F_GETFL and F_SETFL for fcntl #4212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustbot ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the first round of comments. Sorry for the long wait!
@rustbot author
Reminder, once the PR becomes ready for a review, use |
On the latest commit b22019d, I made all the tests in this PR to use isolation mode. |
Just a heads up, this PR will stall for a while due to exam prep, but I will be back on it after rust week. |
This comment has been minimized.
This comment has been minimized.
All feedback has been addressed :) @rustbot ready |
Is rustbot taking a break? @rustbot label -S-waiting-on-author +S-waiting-on-review |
Trying one last time... @rustbot label -S-waiting-on-author |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. :)
@rustbot author
@rustbot ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're almost there, just a few nits. :)
@rustbot author
You know you can land multiple GH suggestions as a single commit? :) Just go to the diff view, there's a button for that. |
Ohh I didn't know that! Clicking one by one is indeed a bit annoying because the webpage will refresh for every commit. Ah I saw the button now :) |
@rustbot ready |
This looks great, thanks! Please squash the commits using @rustbot author |
Done, thanks for the review :) @rustbot ready |
This PR supports
F_SETFL
andF_GETFL
flags forfcntl
. In this implementation,F_SETFL
can only setO_NONBLOCK
flag (and file access mode flag likeO_RDONLY
, but that will be ignored).The interaction between these
fcntl
operations and blocking fd is summarised here.Fixes #4119