Improve wording and description of atomics in the Arc chapter
#430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted my best to improve my original description of atomics. This removes the giant ugly double-blockquote referencing the Rust
alloccrate, which references the Boost documentation. Please let me know if my descriptions are wrong!I also fixed #323 with this edit; it didn't really make sense anyway to have it be a
*mut ArcInner<T>originally as it wouldn't have been possible to mutate the inner value or the refcount (the refcount can be updated through a shared ref with atomics, anyway). I made sure to keep the description of variance, so the reader understands why that is an important property to retain.