Merge pull request #450 from programmerjake/update-llvm-workaround-comment

calebzulawski · web-flow · commit abd5d05ec4de · 2025-03-17T23:33:54.000-04:00
update llvm workaround comment to link to rust tracking issue too
diff --git a/crates/core_simd/src/simd/num/float.rs b/crates/core_simd/src/simd/num/float.rs
@@ -263,7 +263,8 @@ macro_rules! impl_trait {
                 unsafe { core::intrinsics::simd::simd_as(self) }
             }
 
-            // https://github.com/llvm/llvm-project/issues/94694
+            // workaround for https://github.com/llvm/llvm-project/issues/94694 (fixed in LLVM 20)
+            // tracked in: https://github.com/rust-lang/rust/issues/135982
             #[cfg(target_arch = "aarch64")]
             #[inline]
             fn cast<T: SimdCast>(self) -> Self::Cast<T>

Original file line number	Diff line number	Diff line change
`@@ -263,7 +263,8 @@ macro_rules! impl_trait {`
`263`	`263`	`unsafe { core::intrinsics::simd::simd_as(self) }`
`264`	`264`	`}`
`265`	`265`
`266`		`- // https://github.com/llvm/llvm-project/issues/94694`
	`266`	`+ // workaround for https://github.com/llvm/llvm-project/issues/94694 (fixed in LLVM 20)`
	`267`	`+ // tracked in: https://github.com/rust-lang/rust/issues/135982`
`267`	`268`	`#[cfg(target_arch = "aarch64")]`
`268`	`269`	`#[inline]`
`269`	`270`	`fn cast<T: SimdCast>(self) -> Self::Cast<T>`