Skip to content

add examples for shift_elements_{left, right} and rotate_elements_{left, right} #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

folkertdev
Copy link
Contributor

I think the text is just complicated enough to warrant an example. The doctest also shows the wrapping behavior of the implementation (for standard integers, shifting by more bits than the type has is UB (c) or panics (rust)).

Maybe the modulo behavior should be called out more explicitly still?

@folkertdev
Copy link
Contributor Author

Looks like CI is using an older version of rustc? I can reproduce the failures with cargo test but they disappear with cargo +nightly test.

@folkertdev folkertdev force-pushed the element-rotate-example branch from 0c7c94f to 85a494b Compare March 18, 2025 09:34
@calebzulawski calebzulawski merged commit c14f2fc into rust-lang:master Mar 18, 2025
59 checks passed
@calebzulawski
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants