Skip to content

Establish Infrastructure #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

makai410
Copy link
Contributor

  • devtool: A helper for maintaining rustc_public. The main logic for commands like build is implemented here. This PR implements ./x build, ./x test [--bless], ./x fmt [--check], ./x githook and ./x clean. Windows is not supported yet.
  • This PR turns the compiletest crate into a single file, making it possilbe to run test suites using cargo test.

This way we can use `cargo test` to run our test suites.
With that we can simply do things like `./x build`, `./x test`, `./x
fmt`, etc.
@celinval
Copy link
Contributor

Amazing! On the file structure, since this repo is also meant to store files related to the project, can I suggest that we create a rustc_public folder with the code relevant for the crate. Or would that mess up with the josh-sync?

@celinval
Copy link
Contributor

I was also wondering if you could break down the PR a bit more. I think there are changes here that are ready to be merged independently

@makai410
Copy link
Contributor Author

Amazing! On the file structure, since this repo is also meant to store files related to the project, can I suggest that we create a rustc_public folder with the code relevant for the crate. Or would that mess up with the josh-sync?

It seems feasible by writing a filter to the josh, though I haven't tried it yet. IMO it's OK to keep our rustc_public code in the src/ folder, and miri does the same.

I was also wondering if you could break down the PR a bit more. I think there are changes here that are ready to be merged independently

Yea makes sense. I'll split it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants