Make examples coherent with text #3787
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigna
changed the title
ehuss
added
the
T-libs-api
Noratrieb
added
the
not-rfc
|
We generally leave old RFCs alone (https://github.com/rust-lang/rfcs?tab=readme-ov-file#the-rfc-life-cycle), not changing the text in them, other than maybe adding a process note at the top (like 6006f43). I'm inclined to close this as non-a-bug. |
|
Yep, probably nobody reads or follows those description except me—they can stay contradictory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in the API conventions (in imperative) contradicts the text (use third person). This PR corrects the example to fit the text description.
Rendered