internal: vendor query-group-macro in rust-analyzer
#19305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
davidbarsky
force-pushed
the
davidbarsky/vendor-query-group-macro
branch
from
db9115a to
f8be89f
Compare
|
I'll fix that unused warning tomorrow, but I feel like we should hold off on landing this until on Monday, at the easliest. |
lnicola
reviewed
Mar 7, 2025
|
I realized (and fixed, locally) why we were getting a dead code warning: the |
davidbarsky
force-pushed
the
davidbarsky/vendor-query-group-macro
branch
from
baf3bb9 to
e20d12a
Compare
|
Alright, flattened the match expression and fixed the dead code warning. I'd like to squash those 3 commits into one before landing this, however. |
davidbarsky
force-pushed
the
davidbarsky/vendor-query-group-macro
branch
2 times, most recently
from
09f06f4 to
ff75ff5
Compare
davidbarsky
commented
Mar 7, 2025
davidbarsky
force-pushed
the
davidbarsky/vendor-query-group-macro
branch
3 times, most recently
from
ffd90d0 to
fbb037c
Compare
davidbarsky
force-pushed
the
davidbarsky/vendor-query-group-macro
branch
from
fbb037c to
7a7ff47
Compare
Veykril
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency of #18964. This shouldn't land until we get a Salsa release out, which depends on fixing the
powerpcbuild failures.