Skip to content

remove pref_align_of intrinsic handling, rename {min_=>}align_of{,_val} #19984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2025

Conversation

WaffleLapkin
Copy link
Member

@WaffleLapkin WaffleLapkin marked this pull request as ready for review June 12, 2025 12:06
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 12, 2025
@ChayimFriedman2
Copy link
Contributor

We should wait until that PR is merged so that std switches to the new name.

@lnicola
Copy link
Member

lnicola commented Jun 12, 2025

Ideally we'd support both names for a while, so people who are not using nightly won't have a worse experience, but I'm not sure of the implications in this case (stuff might be broken already).

@WaffleLapkin
Copy link
Member Author

I guess I could leave min_align_of*, add align_of*, and leave a fixme to remove min_align_of* later?

@WaffleLapkin
Copy link
Member Author

I did the above, this is ready for review

@Veykril Veykril added this pull request to the merge queue Jun 14, 2025
Merged via the queue into rust-lang:master with commit fe5a925 Jun 14, 2025
14 checks passed
@WaffleLapkin WaffleLapkin deleted the unprefer_align branch June 14, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants