Add auto trait name for generate_trait_from_impl #20299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
Why specifically from the first method, or from methods at all? I'm not sure this is advantageous. |
|
Having placeholder snippet group, incorrect name is irrelevant |
Auto generate trait name from first method.
Input:
```rust
impl S$0 {
fn foo() {}
}
```
Old output:
```rust
trait NewTrait {
fn foo();
}
impl NewTrait for S {
fn foo() {}
}
```
This PR output:
```rust
trait Foo {
fn foo();
}
impl Foo for S {
fn foo() {}
}
```
A4-Tacks
force-pushed
the
auto-trait-name-for-gen-trait-from-impl
branch
from
c992237 to
70552cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto generate trait name from first method.
Input:
Old output:
This PR output: