Migrate convert_tuple_struct_to_named_struct assist to use SyntaxEditor
#20311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Hmikihiro
force-pushed
the
migrate_convert_tuple_struct_to_named_struct
branch
from
3025fab to
a74d6ec
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
has-merge-commits
S-waiting-on-author
Signed-off-by: Hayashi Mikihiro <[email protected]>
…` to SyntaxEditor Signed-off-by: Hayashi Mikihiro <[email protected]>
…ditor' Signed-off-by: Hayashi Mikihiro <[email protected]>
Hmikihiro
force-pushed
the
migrate_convert_tuple_struct_to_named_struct
branch
from
cd07345 to
475ebb8
Compare
rustbot
removed
has-merge-commits
S-waiting-on-author
| let tuple_fields_text_range = tuple_fields.syntax().text_range(); | ||
|
|
||
| edit.edit_file(ctx.vfs_file_id()); | ||
| let record_fields = ast::make::record_field_list(record_fields).clone_for_update(); |
There was a problem hiding this comment.
I think it would be good to use
especially when we need .clone_for_update() here. Though it still calls clone_for_update() in its body, at least we can gather them up in one place and bulk-fix later.
| @@ -245,7 +275,7 @@ fn generate_names(fields: impl Iterator<Item = ast::TupleField>) -> Vec<ast::Nam | |||
| .enumerate() | |||
| .map(|(i, _)| { | |||
| let idx = i + 1; | |||
| ast::make::name(&format!("field{idx}")) | |||
| ast::make::name(&format!("field{idx}")).clone_for_update() | |||
There was a problem hiding this comment.
Same as the above, with
Everything else looks good to me!
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285