impl Display type hint inlay hints at the end of the line #4318 #21322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asukaminato0721
force-pushed
the
4318
branch
from
36d28e4 to
38b8e8c
Compare
rustbot
added
the
S-waiting-on-review
There was a problem hiding this comment.
Pull request overview
This PR implements support for rendering type inlay hints at the end of the line (after the statement terminator) instead of inline immediately after the binding identifier, addressing issue #4318.
Key Changes:
- Added a new configuration option
rust-analyzer.inlayHints.typeHints.locationwith valuesinline(default) andend_of_line - Extended hint ranges to span to the end of containing statements when end-of-line placement is selected
- Updated both binding pattern and chaining hint producers to support the new placement option
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| editors/code/package.json | Adds VS Code configuration setting for type hints location with enum values and descriptions |
| docs/book/src/configuration_generated.md | Adds user-facing documentation for the new configuration option |
| crates/rust-analyzer/src/config.rs | Defines TypeHintsLocation enum, adds config field, maps to IDE layer, and provides JSON schema metadata |
| crates/rust-analyzer/src/cli/analysis_stats.rs | Updates analysis stats CLI to use default Inline placement |
| crates/ide/src/static_index.rs | Updates static index to use default Inline placement and imports TypeHintsPlacement |
| crates/ide/src/lib.rs | Exports TypeHintsPlacement for external use |
| crates/ide/src/inlay_hints/chaining.rs | Implements end-of-line placement for chaining hints by extending range to newline token, adds test coverage |
| crates/ide/src/inlay_hints/bind_pat.rs | Implements end-of-line placement for binding pattern hints by extending range to let statement end, adds test coverage |
| crates/ide/src/inlay_hints.rs | Defines TypeHintsPlacement enum and adds type_hints_placement field to InlayHintsConfig, updates test configs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4318
Added a new rust-analyzer.inlayHints.typeHints.location setting (values inline/end_of_line, default inline) and plumbed it through the server config so clients can request end-of-line placement as described in issue.
Updated the binding-type inlay producer so that when end_of_line is selected it extends the hint range to the end of the surrounding let statement and forces a left pad, which makes the client render the type after the statement terminator.