Fix type completeness issues with clang 22 #3278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In llvm/llvm-project#147835, Clang's AST changed so that a TagType's decl will not necessarily refer to the type's definition, but to the exact declaration which produced the type. For example, in typedef struct S T; struct S { int x; }; the 'struct S' type would refer to the incomplete type decl in the typedef, causing CompInfo to fail to see the type's definition. This patch inserts a call to use the definition when available. It fixes the original test case in #3275 and most of the test failures caused by the Clang change but not all.
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 28, 2025
This picks up rust-lang/rust-bindgen#3278 and also adds the tests to the build process to catch such problems earlier. Bug: 440975178 Change-Id: Id919ff4d6191ab04267d961eef3e993665788052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6890874 Commit-Queue: Nico Weber <[email protected]> Reviewed-by: Nico Weber <[email protected]> Auto-Submit: Hans Wennborg <[email protected]> Commit-Queue: Hans Wennborg <[email protected]> Cr-Commit-Position: refs/heads/main@{#1507661}
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Sep 2, 2025
Summary: This reverts my folly workaround from {D80186965} because the bindgen fix [bindgen#3278](rust-lang/rust-bindgen#3278) has made it into fbsource's version of bindgen since {D81525185}.
Reviewed By: diliop
Differential Revision: D81525186
fbshipit-source-id: 3d36156e1f913f050f9af26a1938b65025aa8779
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3275
Fixes #3264
Closes #3277 (included here squashed)