codegen: Support new-type-alias constants #3288
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurer
force-pushed
the
wrap-newtype-consts
branch
2 times, most recently
from
25e3a0b to
abe5208
Compare
|
String new-type-alias constants are not currently supported by this PR because |
maurer
force-pushed
the
wrap-newtype-consts
branch
4 times, most recently
from
cf52008 to
1c2d65f
Compare
maurer
force-pushed
the
wrap-newtype-consts
branch
from
1c2d65f to
f369096
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3287
This addresses the issue by checking if the type the constant is being generated for has a newtype alias applied to it.