fix: option_if_let_else FP when value partially moved
#14209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
r? clippy |
|
r? clippy |
blyxyas
requested changes
Mar 13, 2025
There was a problem hiding this comment.
This PR has changed my mind in introducing new visitors, althought it still has to be done very carefully to avoid needless work / bugs, this use is very elegant.
Some documentation would be greatly appreciated, I left you some suggestions.
Thanks for the contribution! ❤️
|
I've just checked lintcheck, and it seems that this is removing a lot of real positives :/ |
profetia
force-pushed
the
issue13964
branch
2 times, most recently
from
6d6363f to
c7d776b
Compare
Should be better now. |
|
r? @blyxyas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13964
The lint
option_map_unwrap_orused to have a similar issue in #10579, so I borrowed its solution to fix this one.changelog: [
option_if_let_else]: fix FP when value partially moved