Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: iter_cloned_collect FP with custom From/IntoIterator impl #14473

Merged
merged 1 commit into from
Apr 8, 2025
Merged

fix: iter_cloned_collect FP with custom From/IntoIterator impl #14473

merged 1 commit into from
Apr 8, 2025
+69 −3

Conversation

profetia
Copy link
Contributor

Closes #9119

changelog: [iter_cloned_collect]: fix FP with custom From/IntoIterator impl

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 25, 2025
@profetia
Copy link
Contributor Author

profetia commented Apr 8, 2025

r? clippy

@rustbot rustbot assigned Alexendoo and unassigned blyxyas Apr 8, 2025
@samueltardieu
Copy link
Contributor

r? @samueltardieu

@rustbot rustbot assigned samueltardieu and unassigned Alexendoo Apr 8, 2025
samueltardieu
samueltardieu requested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Apr 8, 2025
@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@profetia
Copy link
Contributor Author

profetia commented Apr 8, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Apr 8, 2025
@samueltardieu samueltardieu added this pull request to the merge queue Apr 8, 2025
@samueltardieu
Copy link
Contributor

Thanks!

Merged via the queue into rust-lang:master with commit 1a1ad5e Apr 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueltardieu samueltardieu samueltardieu approved these changes

Assignees

@samueltardieu samueltardieu

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iter_cloned_collect false positive with custom From/IntoIterator impl
5 participants
@profetia @rustbot @samueltardieu @Alexendoo @blyxyas