Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: enable checking doc attributes on entrypoint function to fix #14491 #14505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: enable checking doc attributes on entrypoint function to fix #14491 #14505

wants to merge 1 commit into from
+62 −4

Conversation

longfangsong
Copy link

Fixes #14491

I'm not so sure about the expected behaviour here, I presume that one should document panics and errors on main?

So I remove the is_entrypoint_fn here.

changelog: [missing_panics_doc & missing_panics_doc]: enable checking doc attributes on entrypoint function

@rustbot
Copy link
Collaborator

rustbot commented Mar 30, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 30, 2025
@longfangsong longfangsong mentioned this pull request Mar 30, 2025
Open
@rustbot
Copy link
Collaborator

rustbot commented Mar 31, 2025

☔ The latest upstream changes (possibly d28d234) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dswij dswij

Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to expect the missing_panics_doc and missing_errors_doc lints on main function
3 participants
@longfangsong @rustbot @dswij