Ensure that peeling does not recurse into macros #14527
Merged
+38
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
We do not want to remove casts done inside macros. Also, when printing the suggestion, take it from the same context as the origin expression (the root context).
samueltardieu
changed the title
samueltardieu
force-pushed
the
ptr-eq-macros
branch
from
dfca8ff to
db4bd96
Compare
samueltardieu
added
the
beta-nominated
|
r? clippy |
|
@flip1995 Is there anything else to do to bring this to your attention? (I've set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to remove casts done inside macros. Also, when printing the suggestion, take it from the same context as the origin expression (the root context).
Problems found while working on #14526, but should be merged even if #14526 is not.
changelog: none