check f16 and f128 in float_equality_without_abs #15054
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
y21
reviewed
Jun 14, 2025
| && let ExprKind::Path(ref epsilon_path) = rhs.kind | ||
| && let Res::Def(DefKind::AssocConst, def_id) = cx.qpath_res(epsilon_path, rhs.hir_id) | ||
| && ([sym::f32_epsilon, sym::f64_epsilon].into_iter().any(|sym| cx.tcx.is_diagnostic_item(sym, def_id))) | ||
| && (sym_epsilon.into_iter().any(|sym| cx.tcx.is_diagnostic_item(sym, def_id))) |
There was a problem hiding this comment.
Suggestion: you can use get_diagnostic_item to avoid a bunch of query overhead, something like
Suggested change
| && (sym_epsilon.into_iter().any(|sym| cx.tcx.is_diagnostic_item(sym, def_id))) | |
| && matches!(cx.tcx.get_diagnostic_name(def_id), Some(sym::f16_epsilon | sym::f32_epsilon | sym::f64_epsilon | sym::f128_epsilon)) |
There was a problem hiding this comment.
It's too long so rustfmt complains error[internal]: line formatted, but exceeded maximum width.
There was a problem hiding this comment.
You can split the line by hand and make rustfmt happy.
|
Can you also add tests for this? It seems like there's also a f16_f128 FIXME in the code that could easily be resolved in the same PR here: |
Added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup of rust-lang/rust#141874
changelog: check f16 and f128 in float_equality_without_abs