feat(strlen_on_c_strings): mention the specific type (CString or CStr)
#16391
+99
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Collaborator
|
rustbot has assigned @samueltardieu. Use |
ada4a
force-pushed
the
strlen_on_c_strings
branch
from
9c58080 to
f36c4f9
Compare
Member
|
Nit: should we use "use ... instead"(or just "use") instead of "try"? |
For simplicity's sake, this also changes the lint to always suggest `to_bytes`, as it is somewhat hard to find out whether a type could dereference to `CString` (which is what `as_bytes` would require)
ada4a
force-pushed
the
strlen_on_c_strings
branch
from
f36c4f9 to
49c8614
Compare
Contributor
Author
|
Given that this is an autofix.. yeah probably. Repeating the whole |
rustbot
removed
the
S-waiting-on-review
Member
Contributor
Author
|
Yeah that was a weird brain hiccup – I did realize that this would cause a conflict, and did want to avoid it... but just didn't. Apologies to you and @Tigls, I'll do better next time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vague "or" was a bit silly
changelog: [
strlen_on_c_strings]: mention the specific type (CStringorCStr)changelog: [
strlen_on_c_strings]: lint all types that dereference toCStr