Skip to content

document reqd. approvals for target changes #834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

document reqd. approvals for target changes #834

wants to merge 2 commits into from

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Apr 16, 2025 •
edited by rustbot
Loading

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2025

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 16, 2025
@davidtwco davidtwco force-pushed the new-target-approvals branch from fe37ec5 to 06d0525 Compare April 16, 2025 15:59
@davidtwco @jieyouxu
remove extra space
d17ca36 
Co-authored-by: 许杰友 Jieyou Xu (Joe) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgross35 tgross35 tgross35 left review comments

@jieyouxu jieyouxu jieyouxu left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@estebank estebank

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@davidtwco @rustbot @tgross35 @jieyouxu @estebank