Skip to content

Document triagebot review queue tracking #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 22, 2025

This PR documents the new review queue tracking, as currently implemented in triagebot. Opening as a draft, because we should probably first consult with rustc contributors if they are fine with this logic and if they want to change something first (e.g. always enabling r?) before we enable the new logic.

The PR that would enable this on rust-lang/rust is here.

CC @apiraino @jieyouxu

Rendered

@Kobzol Kobzol force-pushed the review-queue-tracking branch from 7fd2d25 to bcc67d3 Compare May 22, 2025 12:28
@Kobzol Kobzol marked this pull request as ready for review May 29, 2025 06:21
@rustbot
Copy link
Collaborator

rustbot commented May 29, 2025

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 29, 2025
@Kobzol Kobzol mentioned this pull request May 29, 2025
@Kobzol Kobzol force-pushed the review-queue-tracking branch from bcc67d3 to 36164b1 Compare May 29, 2025 08:43
@Kobzol
Copy link
Contributor Author

Kobzol commented May 29, 2025

Updated with the new direct review request logic (rust-lang/triagebot#2014.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 29, 2025
…ouxu

Enable review queue tracking

This PR enables the new review queue tracking assignment logic implemented in triagebot. It is documented in rust-lang/rust-forge#853.
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some small nits. Feel free to merge with whatever changes you like.

rust-timer added a commit to rust-lang/rust that referenced this pull request May 30, 2025
Rollup merge of #141384 - Kobzol:enable-review-prefs, r=jieyouxu

Enable review queue tracking

This PR enables the new review queue tracking assignment logic implemented in triagebot. It is documented in rust-lang/rust-forge#853.
@Kobzol Kobzol merged commit dde9a45 into rust-lang:master May 30, 2025
1 check passed
@Kobzol Kobzol deleted the review-queue-tracking branch May 30, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants