-
Notifications
You must be signed in to change notification settings - Fork 192
Document triagebot review queue tracking #853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fd2d25
to
bcc67d3
Compare
Closed
bcc67d3
to
36164b1
Compare
Updated with the new direct review request logic (rust-lang/triagebot#2014. |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 29, 2025
…ouxu Enable review queue tracking This PR enables the new review queue tracking assignment logic implemented in triagebot. It is documented in rust-lang/rust-forge#853.
ehuss
approved these changes
May 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Just some small nits. Feel free to merge with whatever changes you like.
rust-timer
added a commit
to rust-lang/rust
that referenced
this pull request
May 30, 2025
Rollup merge of #141384 - Kobzol:enable-review-prefs, r=jieyouxu Enable review queue tracking This PR enables the new review queue tracking assignment logic implemented in triagebot. It is documented in rust-lang/rust-forge#853.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents the new review queue tracking, as currently implemented in triagebot. Opening as a draft, because we should probably first consult with rustc contributors if they are fine with this logic and if they want to change something first (e.g. always enabling
r?
) before we enable the new logic.The PR that would enable this on
rust-lang/rust
is here.CC @apiraino @jieyouxu
Rendered