Allow the Ace keybinding and theme to be stale when changing it - #1266
Open
shepmaster wants to merge 2 commits into
Open
Allow the Ace keybinding and theme to be stale when changing it#1266shepmaster wants to merge 2 commits into
shepmaster wants to merge 2 commits into
Conversation
It's built-in to Ace itself.
This also prevents the editor from unmounting and remounting when the
theme/keybinding change, which is a bit nicer from the user's point of
view.
Mainly I'm doing this to work around an issue where the Ace tokenizer
is still running even after `this.doc` has been set to `null` when the
editor is destroyed, which results in an error in this code when
changing the theme:
```js
BackgroundTokenizer.prototype.$tokenizeRow = function (row) {
var line = this.doc.getLine(row);
```
shepmaster
force-pushed
the
leave-me-in-suspense
branch
from
August 7, 2026 00:48
1609bf3 to
3ff2f9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.