Skip to content

Raw comments #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 27, 2025
Merged

Raw comments #298

merged 7 commits into from
Feb 27, 2025

Conversation

nikomatsakis
Copy link
Contributor

@nikomatsakis nikomatsakis commented Feb 27, 2025

Modifies the code to not use an LLM and instead paste raw comments in a details tag.

Review from @lqd requested

Rendered

@nikomatsakis nikomatsakis requested a review from lqd February 27, 2025 17:44
@nikomatsakis
Copy link
Contributor Author

cc #297

@lqd
Copy link
Member

lqd commented Feb 27, 2025

From the hackmd results I think this also misses issues where no progress has ever been posted from being categorized as a goal for which "no updates have been posted this period".

edit: the above may be a rendering issue on hackmd, or you may have fixed it in the PR by adding the <!-- --> separators which aren't in the hackmd; locally I have the expected content and rendering.

(I also noticed the pre-existing issue that templates/updates.hbs hardcodes the 2024h2 period in its header. I've already fixed that in the hackmd)

@nikomatsakis
Copy link
Contributor Author

@lqd I tweaked the output, I think it's better now (I didn't fix the pluralizing, though)

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with/without the last couple nits above -- I can take care of these tomorrow anyways.

@nikomatsakis nikomatsakis merged commit c869852 into rust-lang:main Feb 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants