Rollup of 7 pull requests #103714

matthiaskrgr · 2022-10-29T06:57:38Z

Successful merges:

Make CStr::from_ptr const. #102961 (Make CStr::from_ptr const.)
Add test for issue 98634 #103342 (Add test for issue 98634)
Note scope of TAIT more accurately #103383 (Note scope of TAIT more accurately)
Specialize ToString for Symbol #103656 (Specialize ToString for Symbol)
rustdoc: remove redundant CSS/DOM div.search-container #103663 (rustdoc: remove redundant CSS/DOM div.search-container)
rustdoc-json-types: Improve ItemSummary::path docs #103664 (rustdoc-json-types: Improve ItemSummary::path docs)
Add a test for TAIT used with impl/dyn Trait inside RPIT #103704 (Add a test for TAIT used with impl/dyn Trait inside RPIT)

Failed merges:

Rename some OwnerId fields. #103618 (Rename some OwnerId fields.)

r? @ghost
@rustbot modify labels: rollup

This wrapper DIV was originally added in 89e1fb3, when it allowed the search bar's size to be calculated without using `calc()`. This `width` hack can be removed using flexbox.

…r=oli-obk Make `CStr::from_ptr` `const`. Should be included in rust-lang#101719. cc ``@WaffleLapkin``

…, r=compiler-errors Add test for issue 98634 Fixes rust-lang#98634

Note scope of TAIT more accurately This maybe explains why the person was confused in rust-lang#101897, since we say "same module" but really should've said "same impl". r? ``@oli-obk``

…piler-errors Specialize ToString for Symbol

…er, r=GuillaumeGomez rustdoc: remove redundant CSS/DOM `div.search-container` Preview: https://notriddle.com/notriddle-rustdoc-demos/search-container/test_dingus/fn.test.html This wrapper DIV was originally added in 89e1fb3, when it allowed the search bar's size to be calculated without using `calc()`. This `width` hack can be removed using flexbox.

…au,GuillaumeGomez rustdoc-json-types: Improve ItemSummary::path docs Somewhat inspired by the doc changes from rust-lang#103085 (cc ``@Urgau)`` r? ``@GuillaumeGomez``

…mpiler-errors Add a test for TAIT used with impl/dyn Trait inside RPIT close rust-lang#101750

matthiaskrgr · 2022-10-29T06:57:58Z

@bors r+ rollup=never p=7

bors · 2022-10-29T06:58:00Z

📌 Commit cc8040e has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2022-10-29T09:21:39Z

⌛ Testing commit cc8040e with merge 33b530e...

bors · 2022-10-29T12:06:57Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 33b530e to master...

rust-timer · 2022-10-29T12:08:56Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#103704	d5b29706133425f59f30f0cd5474193908966203
#103664	6915d4a6413e70dc52ebc4aa10877bdb17f3c967
#103663	320a9e0c6e6a825e3e663bdb5ac364e47fb73c51
#103656	8124dba26868e0f30f981372dabc4563701acdb9
#103383	53477e86de2b10bdc5365fb2976fc5ae4e7c4afa
#103342	cfbc291a72c25d7f5957d7155a1eb08dde20e1a6
#102961	ffc8396470e840aedad49a4188adce0f5c674825

previous master: 607878d069

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2022-10-29T13:26:02Z

Finished benchmarking commit (33b530e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.4%, 0.7%]	5
Improvements ✅ (primary)	-1.3%	[-1.4%, -1.2%]	2
Improvements ✅ (secondary)	-1.9%	[-4.0%, -0.4%]	12
All ❌✅ (primary)	-1.3%	[-1.4%, -1.2%]	2

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.4%	[-2.8%, -2.1%]	6
All ❌✅ (primary)	-	-	0

lqd · 2022-10-29T13:42:28Z

maybe the deeply-nested-multi regressons is real, but there's nothing obvious in the rolled up PRs ?

The wins are noise though.

rylev · 2022-11-02T13:30:31Z

Even if the regressions are real they're too small for this to be worth investigation.

@rustbot label: +perf-regression-triaged

reitermarkus and others added 16 commits October 12, 2022 13:01

Make CStr::from_ptr const.

328f817

Update docs for CStr::from_ptr.

36dbb07

Note scope of TAIT more accurately

4accf83

rustdoc: remove redundant div.search-container

509d8ad

This wrapper DIV was originally added in 89e1fb3, when it allowed the search bar's size to be calculated without using `calc()`. This `width` hack can be removed using flexbox.

add test for issue 98634

92b314b

rustdoc-json-types: Improve ItemSummary::path docs

064ad83

Remove unneeded attribute.

b3f9277

Add a test for TAIT used with impl/dyn Trait inside RPIT

6bc5fdd

Specialize ToString for Symbol

298253a

Rollup merge of rust-lang#102961 - reitermarkus:const-cstr-from-ptr, …

b3ca68f

…r=oli-obk Make `CStr::from_ptr` `const`. Should be included in rust-lang#101719. cc ``@WaffleLapkin``

Rollup merge of rust-lang#103342 - Rageking8:add-test-for-issue-98634…

67c469f

…, r=compiler-errors Add test for issue 98634 Fixes rust-lang#98634

Rollup merge of rust-lang#103383 - compiler-errors:tait-scope, r=oli-obk

790a716

Note scope of TAIT more accurately This maybe explains why the person was confused in rust-lang#101897, since we say "same module" but really should've said "same impl". r? ``@oli-obk``

Rollup merge of rust-lang#103656 - camsteffen:symbol-to-string, r=com…

f41b1bf

…piler-errors Specialize ToString for Symbol

Rollup merge of rust-lang#103664 - aDotInTheVoid:rdj-path-docs, r=Urg…

2ea6611

…au,GuillaumeGomez rustdoc-json-types: Improve ItemSummary::path docs Somewhat inspired by the doc changes from rust-lang#103085 (cc ``@Urgau)`` r? ``@GuillaumeGomez``

Rollup merge of rust-lang#103704 - xxchan:xxchan/applicable-bug, r=co…

cc8040e

…mpiler-errors Add a test for TAIT used with impl/dyn Trait inside RPIT close rust-lang#101750

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 29, 2022

bors merged commit 33b530e into rust-lang:master Oct 29, 2022

rustbot added this to the 1.66.0 milestone Oct 29, 2022

bors mentioned this pull request Oct 29, 2022

rustdoc: add hash to filename of toolchain files #101702

Merged

rustbot added the perf-regression Performance regression. label Oct 29, 2022

rustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 2, 2022

matthiaskrgr deleted the rollup-kajt3i8 branch December 22, 2022 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 7 pull requests #103714

Rollup of 7 pull requests #103714

Uh oh!

matthiaskrgr commented Oct 29, 2022

Uh oh!

matthiaskrgr commented Oct 29, 2022

Uh oh!

bors commented Oct 29, 2022

Uh oh!

bors commented Oct 29, 2022

Uh oh!

bors commented Oct 29, 2022

Uh oh!

rust-timer commented Oct 29, 2022

Uh oh!

rust-timer commented Oct 29, 2022

Uh oh!

lqd commented Oct 29, 2022

Uh oh!

rylev commented Nov 2, 2022

Uh oh!

Uh oh!

Rollup of 7 pull requests #103714

Rollup of 7 pull requests #103714

Uh oh!

Conversation

matthiaskrgr commented Oct 29, 2022

Uh oh!

matthiaskrgr commented Oct 29, 2022

Uh oh!

bors commented Oct 29, 2022

Uh oh!

bors commented Oct 29, 2022

Uh oh!

bors commented Oct 29, 2022

Uh oh!

rust-timer commented Oct 29, 2022

Uh oh!

rust-timer commented Oct 29, 2022

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

lqd commented Oct 29, 2022

Uh oh!

rylev commented Nov 2, 2022

Uh oh!

Uh oh!