Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2022

Could not determine reviewer from Mark-Simulacrum.

@rustbot
Copy link
Collaborator

rustbot commented Oct 29, 2022

@Mark-Simulacrum: no appropriate reviewer found, use r? to override

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Oct 29, 2022
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=10

@bors
Copy link
Collaborator

bors commented Oct 29, 2022

📌 Commit 4cc03c1 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2022
@bors
Copy link
Collaborator

bors commented Oct 29, 2022

⌛ Testing commit 4cc03c1 with merge 69810e38352200a12413b252cc6db4f0796e160b...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Oct 29, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 29, 2022
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 29, 2022
@Mark-Simulacrum
Copy link
Member Author

It looks like we're failing here because the version bump caused us to need a rebuild of LLVM for all the builders that are caching it (as of #99967). Normally that's not a problem, but python3 "$X_PY" test --stage 2 src/tools/miri --target i686-pc-windows-msvc currently at least is breaking on that. It seems possible we don't actually need an LLVM build here and the check/download of it is just too eager, but that will need to be fixed in a follow-up PR.

@Mark-Simulacrum
Copy link
Member Author

@bors r+ p=5

@bors
Copy link
Collaborator

bors commented Oct 29, 2022

📌 Commit b0db70e has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2022
@bors
Copy link
Collaborator

bors commented Oct 29, 2022

⌛ Testing commit b0db70e with merge 15ee24a...

@bors
Copy link
Collaborator

bors commented Oct 30, 2022

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 15ee24a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 30, 2022
@bors bors merged commit 15ee24a into rust-lang:master Oct 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Oct 30, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (15ee24a): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.2%, 1.4%] 2
Regressions ❌
(secondary)
2.1% [0.5%, 4.1%] 12
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.3% [1.2%, 1.4%] 2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
5.3% [5.3%, 5.3%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-4.0% [-4.0%, -4.0%] 1
All ❌✅ (primary) 5.3% [5.3%, 5.3%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.4% [2.1%, 2.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

@rustbot rustbot added the perf-regression Performance regression. label Oct 30, 2022
@nnethercote
Copy link
Contributor

These "regressions" are just noise, the relevant benchmarks have been noisy lately.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 30, 2022
@Mark-Simulacrum Mark-Simulacrum deleted the new-version branch October 31, 2022 02:33
Aaron1011 pushed a commit to Aaron1011/rust that referenced this pull request Jan 6, 2023
…Simulacrum

Bump to 1.67.0

r? `@Mark-Simulacrum`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants