-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Add additional float constants #103836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional float constants #103836
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
@rustbot label +T-libs-api -T-libs |
SQRT_3 is useful.
|
I've left the addition of ln(3) (and potential others) as an open question on the tracking issue: #103883 This PR just includes the ones in C++ but not Rust, as discussed in the ACP: rust-lang/libs-team#119 (comment) |
@rustbot label -S-waiting-on-review +S-waiting-on-ACP |
r? @thomcc |
This has ACP+ and these are unstable, so @bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (1bd0430): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 631.432s -> 630.025s (-0.22%) |
Initial implementation of this ACP: rust-lang/libs-team#119. [Accepted]
Tracking issue: #103883
The values for the constants are copied from the
libstdc++
source code.