Skip to content

Conversation

oskgo
Copy link
Contributor

@oskgo oskgo commented Feb 6, 2023

This is a refactoring to simplify future work on alignment such as in #11924 and rust-lang/rfcs#3204.

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 6, 2023
@oskgo
Copy link
Contributor Author

oskgo commented Feb 6, 2023

r? ghost

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2023

Failed to set assignee to ghost: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@eholk
Copy link
Contributor

eholk commented Feb 7, 2023

@rustbot author

(Setting as waiting on author since this is marked as a draft still)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 7, 2023
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@oskgo oskgo force-pushed the split-align-from-layout branch from b9e912f to 4994077 Compare February 20, 2023 21:06
@rust-log-analyzer

This comment has been minimized.

@oskgo
Copy link
Contributor Author

oskgo commented Mar 7, 2023

I don't have the confidence to make these changes without mentoring yet, so I'll close this. I might pick it back up once I'm more comfortable or if someone wants to mentor work on alignment, but this PR can be considered abandoned.

@oskgo oskgo closed this Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants