Rework coroutine transform to be more flexible in preparation for async generators #118418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cjgillot (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
☔ The latest upstream changes (presumably #118420) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This was subsumed by #118420. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My work-in-progress implementation of
async genblocks has a slightly more involved coroutine desugaring, since the generators must returnPoll<Option<T>>, instead of justPoll<T>orOption<T>. This means that thestate_adt_refandstate_argsfor the current coroutine transformTransformVisitorare not sufficient.This PR inlines the
TransformVisitor::coroutine_state_adt_and_variant_idxfunction into its call-sites, simplifies some logic, and reworksTransformVisitor::make_stateto be a bit more clear and easy to read.