core: introduce split_at{,_mut}_checked #118578

mina86 · 2023-12-03T17:58:15Z

Introduce split_at_checked and split_at_mut_checked methods to slices
types (including str) which are non-panicking versions of split_at and
split_at_mut respectively. This is analogous to get method being
non-panicking version of indexing.

rustbot · 2023-12-03T17:58:23Z

r? @m-ou-se

(rustbot has picked a reviewer for you, use r? to override)

mina86 · 2023-12-28T15:28:18Z

@rustbot label -S-waiting-on-ACP +S-waiting-on-review

rustbot · 2023-12-28T15:28:21Z

Failed to set assignee to label: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

tgross35

Looks pretty good, mostly docs

library/core/src/slice/mod.rs

tgross35 · 2024-01-10T08:51:17Z

library/core/src/slice/mod.rs

+    ///
+    /// Returns `None` if `mid > len`.
+    ///
+    /// # Examples


I seem to recall a PR that removed a lot of # Examples headers whenever there was only one example, but it doesn't really matter (I know this is consistent)

library/core/src/slice/mod.rs

library/core/src/str/mod.rs

rustbot · 2024-01-10T11:08:13Z

There are merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.

You can start a rebase with the following commands:

$ # rebase
$ git rebase -i master
$ # delete any merge commits in the editor that appears
$ git push --force-with-lease

The following commits are merge commits:

adad1f4

bors · 2024-01-20T05:40:54Z

☔ The latest upstream changes (presumably #120136) made this pull request unmergeable. Please resolve the merge conflicts.

tgross35 · 2024-01-20T05:50:24Z

@mina86 comment @rustbot ready whenever you are ready for a re-review (you'll have to rebase and squash your commits before merge still)

Introduce split_at_checked and split_at_mut_checked methods to slices types (including str) which are non-panicking versions of split_at and split_at_mut respectively. This is analogous to get method being non-panicking version of indexing.

mina86 · 2024-01-20T14:20:52Z

@rustbot ready

library/core/src/slice/mod.rs

library/core/src/str/mod.rs

library/core/src/slice/mod.rs

dtolnay

Thanks!

dtolnay · 2024-01-21T19:18:51Z

@bors r+

bors · 2024-01-21T19:18:54Z

📌 Commit 50cbbef has been approved by dtolnay

It is now in the queue for this repository.

core: introduce split_at{,_mut}_checked Introduce split_at_checked and split_at_mut_checked methods to slices types (including str) which are non-panicking versions of split_at and split_at_mut respectively. This is analogous to get method being non-panicking version of indexing. - rust-lang/libs-team#308 - rust-lang#119128

bors · 2024-01-22T04:33:26Z

⌛ Testing commit 50cbbef with merge e99b66b...

bors · 2024-01-22T08:48:26Z

💥 Test timed out

rust-log-analyzer · 2024-01-22T08:56:59Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

dtolnay · 2024-01-22T09:32:25Z

@bors retry

core: introduce split_at{,_mut}_checked Introduce split_at_checked and split_at_mut_checked methods to slices types (including str) which are non-panicking versions of split_at and split_at_mut respectively. This is analogous to get method being non-panicking version of indexing. - rust-lang/libs-team#308 - rust-lang#119128

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#118578 (core: introduce split_at{,_mut}_checked) - rust-lang#119369 (exclude unexported macro bindings from extern crate) - rust-lang#119408 (xous: misc fixes + add network support) - rust-lang#119943 (std::net: bind update for using backlog as `-1` too.) - rust-lang#119948 (Make `unsafe_op_in_unsafe_fn` migrated in edition 2024) - rust-lang#119999 (remote-test: use u64 to represent file size) - rust-lang#120152 (add help message for `exclusive_range_pattern` error) - rust-lang#120213 (Don't actually make bound ty/const for RTN) - rust-lang#120225 (Fix -Zremap-path-scope typo) Failed merges: - rust-lang#119972 (Add `ErrCode`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#118578 - mina86:c, r=dtolnay core: introduce split_at{,_mut}_checked Introduce split_at_checked and split_at_mut_checked methods to slices types (including str) which are non-panicking versions of split_at and split_at_mut respectively. This is analogous to get method being non-panicking version of indexing. - rust-lang/libs-team#308 - rust-lang#119128

rustbot assigned m-ou-se Dec 3, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 3, 2023

mina86 force-pushed the c branch from 5b6ec2e to e30b9c1 Compare December 3, 2023 17:58

This comment has been minimized.

Sign in to view

mina86 force-pushed the c branch from e30b9c1 to 4a1dd8c Compare December 3, 2023 18:10

This comment has been minimized.

Sign in to view

mina86 force-pushed the c branch from 4a1dd8c to 85dd681 Compare December 3, 2023 18:27

mina86 mentioned this pull request Dec 3, 2023

ACP: Introduce checked_split_at{,_mut} methods rust-lang/libs-team#308

Closed

workingjubilee added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 3, 2023

mina86 mentioned this pull request Dec 19, 2023

Tracking Issue for split_at_checked #119128

Closed

4 tasks

mina86 force-pushed the c branch 2 times, most recently from 5715081 to 00cc349 Compare December 19, 2023 18:45

mina86 changed the title ~~core: introduce checked_split_at{,_mut}~~ core: introduce split_at{,_mut}_checked Dec 19, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Dec 28, 2023

tgross35 reviewed Jan 10, 2024

View reviewed changes

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 10, 2024

mina86 force-pushed the c branch from adad1f4 to 967bfdd Compare January 10, 2024 11:10

core: introduce split_at{,_mut}_checked

755cfbf

Introduce split_at_checked and split_at_mut_checked methods to slices types (including str) which are non-panicking versions of split_at and split_at_mut respectively. This is analogous to get method being non-panicking version of indexing.

mina86 force-pushed the c branch from 967bfdd to 755cfbf Compare January 20, 2024 14:20

dtolnay assigned dtolnay and unassigned m-ou-se Jan 21, 2024

dtolnay requested changes Jan 21, 2024

View reviewed changes

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 21, 2024

review

50cbbef

dtolnay approved these changes Jan 21, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 21, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2024

matthiaskrgr mentioned this pull request Jan 22, 2024

Rollup of 9 pull requests #120231

Closed

This was referenced Jan 22, 2024

Rollup of 10 pull requests #120235

Closed

Rollup of 9 pull requests #120239

Merged

bors merged commit 99b4f80 into rust-lang:master Jan 22, 2024

rustbot added this to the 1.77.0 milestone Jan 22, 2024

mina86 deleted the c branch January 27, 2024 06:46

zhassan-aws mentioned this pull request Feb 15, 2024

Out of memory with Kani 0.46.0 on an s2n-quic harness model-checking/kani#3030

Closed

core: introduce split_at{,_mut}_checked #118578

core: introduce split_at{,_mut}_checked #118578

Uh oh!

Conversation

mina86 commented Dec 3, 2023 • edited by dtolnay Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 3, 2023

Uh oh!

This comment has been minimized.

This comment has been minimized.

mina86 commented Dec 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Dec 28, 2023

Uh oh!

tgross35 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 Jan 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rustbot commented Jan 10, 2024

Uh oh!

bors commented Jan 20, 2024

Uh oh!

tgross35 commented Jan 20, 2024

Uh oh!

mina86 commented Jan 20, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dtolnay left a comment

Choose a reason for hiding this comment

Uh oh!

dtolnay commented Jan 21, 2024

Uh oh!

bors commented Jan 21, 2024

Uh oh!

bors commented Jan 22, 2024

Uh oh!

bors commented Jan 22, 2024

Uh oh!

rust-log-analyzer commented Jan 22, 2024

Uh oh!

dtolnay commented Jan 22, 2024

Uh oh!

Uh oh!

mina86 commented Dec 3, 2023 •

edited by dtolnay

Loading

mina86 commented Dec 28, 2023 •

edited

Loading