Skip to content

Conversation

Mark-Simulacrum
Copy link
Member

This includes backports of:

As well as infrastructure fix:

r? @Mark-Simulacrum

wesleywiser and others added 10 commits December 4, 2023 09:51
If the TargetMachine is disposed after the Context is disposed, it can
lead to use after frees in some cases.

I've observed this happening occasionally on code compiled for
aarch64-pc-windows-msvc using `-Zstack-protector=strong` but other users
have reported AVs from host aarch64-pc-windows-msvc compilers as well.
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Dec 4, 2023
@Mark-Simulacrum
Copy link
Member Author

@bors r+ rollup=never p=10

@bors
Copy link
Collaborator

bors commented Dec 4, 2023

📌 Commit de148ec has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023
@bors
Copy link
Collaborator

bors commented Dec 4, 2023

⌛ Testing commit de148ec with merge a28077b...

@bors
Copy link
Collaborator

bors commented Dec 4, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing a28077b to stable...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 4, 2023
@bors bors merged commit a28077b into rust-lang:stable Dec 4, 2023
@rustbot rustbot added this to the 1.74.1 milestone Dec 4, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 18, 2023
…master, r=Mark-Simulacrum

Copy 1.74.1 release notes to master

- rust-lang#119065
- this cherry-pick 1.74.1 release note from rust-lang#118607(66033ec)

Fixes rust-lang#119065.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 18, 2023
Rollup merge of rust-lang#119068 - sksat:copy-1.74.1-release-note-to-master, r=Mark-Simulacrum

Copy 1.74.1 release notes to master

- rust-lang#119065
- this cherry-pick 1.74.1 release note from rust-lang#118607(66033ec)

Fixes rust-lang#119065.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants