Skip to content

Conversation

tiif
Copy link
Member

@tiif tiif commented Aug 4, 2024

Fixes #125873

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2024
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a better title that actually explained why it ICEd in the first place.

@tiif
Copy link
Member Author

tiif commented Aug 5, 2024

This needs a better title that actually explained why it ICEd in the first place.

Hmm I am not sure what has caused the ICE even after checking #125918, so feel free to suggest any suitable title.

@lcnr
Copy link
Contributor

lcnr commented Aug 5, 2024

there are at least 2 important questions here imo:

  • please add #![feature(closure_lifetime_binder, inline_const)] to the regression test as the "feature not enabled" errors may hide the actual error and are unrelated to the actual issue
  • does it actually require -Zincremental-verify-ich=yes -Cincremental=<dir> -Cdebuginfo=2 to trigger the ICE? because if so, this test doesn't actually verify that this now works

for the name of the test, something like inline-const/using-late-bound-from-closure.rs would likely be more helpful

@tiif
Copy link
Member Author

tiif commented Aug 5, 2024

Thanks for the guidance! I will ping you again after applying the change.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2024
@tiif
Copy link
Member Author

tiif commented Aug 7, 2024

I tested it on:

rustc 1.80.0-nightly (f67a1acc0 2024-06-01)
binary: rustc
commit-hash: f67a1acc04c7ecbf05751b17592dd8d245b75256
commit-date: 2024-06-01
host: x86_64-unknown-linux-gnu
release: 1.80.0-nightly
LLVM version: 18.1.6

It still ICE without -Zincremental-verify-ich=yes -Cincremental=<dir> -Cdebuginfo=2.

Note: The compiler version used in the original issue is (0038c0210 2024-06-01). The commit hash is different, but they are from the same date. I can test it again on the same commit if needed.

As of the latest nightly:

rustc 1.82.0-nightly (60d146580 2024-08-06)
binary: rustc
commit-hash: 60d146580c10036ce89e019422c6bc2fd9729b65
commit-date: 2024-08-06
host: x86_64-unknown-linux-gnu
release: 1.82.0-nightly
LLVM version: 19.1.0

It no longer ICE with or without -Zincremental-verify-ich=yes -Cincremental=<dir> -Cdebuginfo=2.

@tiif
Copy link
Member Author

tiif commented Aug 7, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 7, 2024
@lcnr
Copy link
Contributor

lcnr commented Aug 8, 2024

thanks

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 8, 2024

📌 Commit 8eaef3e has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2024
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Aug 8, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128306 (Update NonNull::align_offset quarantees)
 - rust-lang#128612 (Make `validate_mir` ensure the final MIR for all bodies)
 - rust-lang#128648 (Add regression test)
 - rust-lang#128791 (Don't implement `AsyncFn` for `FnDef`/`FnPtr` that wouldnt implement `Fn`)
 - rust-lang#128795 (Update E0517 message to reflect RFC 2195.)
 - rust-lang#128825 (rm `declared_features` field in resolver)
 - rust-lang#128826 (Only suggest `#[allow]` for `--warn` and `--deny` lint level flags)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#128306 (Update NonNull::align_offset quarantees)
 - rust-lang#128612 (Make `validate_mir` ensure the final MIR for all bodies)
 - rust-lang#128648 (Add regression test)
 - rust-lang#128749 (Mark `{f32,f64}::{next_up,next_down,midpoint}` inline)
 - rust-lang#128795 (Update E0517 message to reflect RFC 2195.)
 - rust-lang#128825 (rm `declared_features` field in resolver)
 - rust-lang#128826 (Only suggest `#[allow]` for `--warn` and `--deny` lint level flags)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 53f2ac3 into rust-lang:master Aug 8, 2024
6 checks passed
@rustbot rustbot added this to the 1.82.0 milestone Aug 8, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Aug 8, 2024
Rollup merge of rust-lang#128648 - tiif:issue-125873, r=lcnr

Add regression test

Fixes rust-lang#125873
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE: cannot convert ReLateParam to a region vid
5 participants