Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple suggestions for malformed crate_type attribute #130923

Closed
wants to merge 7 commits into from
Closed

Allow multiple suggestions for malformed crate_type attribute #130923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8b50267
Allow multiple suggestions for malformed crate_type attribute
Blindspot22 Sep 27, 2024
32d564b
feat: enhanced error message
Blindspot22 Nov 12, 2024
7d0e441
feat: enhanced error message
Blindspot22 Dec 16, 2024
abe0241
feat: refactored list field to support multiple static strings
Blindspot22 Dec 16, 2024
0f5bfcb
feat: multiple suggestions for malformed crate_type attribute
Blindspot22 Jan 24, 2025
9fae9f4
Merge branch 'master' into Support-more-suggestions-in-template-for-b…
Blindspot22 Jan 24, 2025
8e0f119
fix: implemented changes from review
Blindspot22 Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/rustc_builtin_macros/src/cfg_accessible.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ impl MultiItemModifier for Expander {
item: Annotatable,
_is_derive_const: bool,
) -> ExpandResult<Vec<Annotatable>, Annotatable> {
let template = AttributeTemplate { list: Some("path"), ..Default::default() };
let template = AttributeTemplate { list: Some(&["path"]), ..Default::default() };

validate_attr::check_builtin_meta_item(
&ecx.sess.psess,
meta_item,
Expand Down
6 changes: 4 additions & 2 deletions compiler/rustc_builtin_macros/src/derive.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@ impl MultiItemModifier for Expander {
let (sess, features) = (ecx.sess, ecx.ecfg.features);
let result =
ecx.resolver.resolve_derives(ecx.current_expansion.id, ecx.force_mode, &|| {
let template =
AttributeTemplate { list: Some("Trait1, Trait2, ..."), ..Default::default() };
let template = AttributeTemplate {
list: Some(&["Trait1", "Trait2", "..."]),
..Default::default()
};
validate_attr::check_builtin_meta_item(
&sess.psess,
meta_item,
Expand Down
Loading